[PATCH 4.4 39/42] [media] ite-cir: initialize use_demodulator before using it

From: Greg Kroah-Hartman
Date: Tue Jan 24 2017 - 03:33:09 EST

4.4-stable review patch. If anyone has any objections, please let me know.


From: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>

commit 7ec03e60ef81c19b5d3a46dd070ee966774b860f upstream.

Function ite_set_carrier_params() uses variable use_demodulator after
having initialized it to false in some if branches, but this variable is
never set to true otherwise.

This bug has been found using clang -Wsometimes-uninitialized warning

Fixes: 620a32bba4a2 ("[media] rc: New rc-based ite-cir driver for
several ITE CIRs")

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/media/rc/ite-cir.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/media/rc/ite-cir.c
+++ b/drivers/media/rc/ite-cir.c
@@ -263,6 +263,8 @@ static void ite_set_carrier_params(struc

if (allowance > ITE_RXDCR_MAX)
allowance = ITE_RXDCR_MAX;
+ use_demodulator = true;