Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags

From: Johannes Berg
Date: Tue Jan 24 2017 - 10:44:43 EST


On Tue, 2017-01-24 at 16:42 +0100, Amadeusz SÅawiÅski wrote:
> cleanup patch to make use of set_sta_flag()/clear_sta_flag() in
> places
> where we access sta->_flags
>
> Signed-off-by: Amadeusz SÅawiÅski <amadeusz.slawinski@xxxxxxxxx>
> ---
> Ânet/mac80211/sta_info.c | 12 ++++++------
> Â1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index b6cfcf0..6c9cc2f 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -1855,13 +1855,13 @@ int sta_info_move_state(struct sta_info *sta,
> Â switch (new_state) {
> Â case IEEE80211_STA_NONE:
> Â if (sta->sta_state == IEEE80211_STA_AUTH)
> - clear_bit(WLAN_STA_AUTH, &sta->_flags);
> + clear_sta_flag(sta, WLAN_STA_AUTH);

You should try to run this patch sometime :)

johannes