Re: [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks

From: Arnaldo Carvalho de Melo
Date: Tue Jan 24 2017 - 13:54:21 EST


Em Wed, Jan 18, 2017 at 05:41:50PM -0800, Andi Kleen escreveu:
> + memset(&al, 0, sizeof(al));
> + if (end - start > MAXBB - MAXINSN) {
> + if (last)
> + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> + start, end);
> + else
> + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
> + start, end, end - start);
> + return 0;

Those are multiline if/else blocks, one has to use {}, additionally (end
- start) should be, just like the other bits PRI, fixing...

This actually broke the build in some distros, like fedora:24
crossbuilding to ARC-uClibc.

- Arnaldo