Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery

From: Eric W. Biederman
Date: Tue Jan 24 2017 - 17:46:10 EST

"Michael Kerrisk (man-pages)" <mtk.manpages@xxxxxxxxx> writes:

> Hi Eric,
> Do you have any input for this small patch set? I've still to tweak a
> comment as suggested by Trevor King, but otherwise I'd like to know if
> this is good to go for the next merge window.

Apologies I have been bogged down with other things. Basically the
code looks fine, and now that I have caught up with things I will be
happy to merge your for the next merge window.

I do wonder if returning -EOVERFLOW may be more useful than running
the overflow_uid when mapping fails.

Also, now that I think about it. Please let's use (uid_t __user *) for
the type of argp. I think that will be more maintainable in the long
run. Easier to grep for etc.

Neither of these things are big or would prevent me from merging your
change just things that I think would be nice to have.