Re: [PATCH] nvdimm: constify device_type structures

From: Joe Perches
Date: Tue Jan 24 2017 - 21:37:31 EST


On Wed, 2017-01-25 at 00:54 +0530, Bhumika Goyal wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to declaration of device_type structure.
>
> File size before:
> text data bss dec hex filename
> 19278 3199 16 22493 57dd nvdimm/namespace_devs.o
>
> File size after:
> text data bss dec hex filename
> 19929 3160 16 23105 5a41 nvdimm/namespace_devs.o

Fine, but are you sure about the sizes?

It seems odd the text went up 651 bytes
while the data went down just 39 bytes.