Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900
From: Guenter Roeck
Date: Wed Jan 25 2017 - 06:51:52 EST
On 01/25/2017 03:12 AM, Pavel Machek wrote:
The hwmon name attribute must not include '-', as documented in
Before reverting, can you please try if this patch works or not?
Not really. Revert now. Sorry.
Are you sure? This does not look equivalent to me at all.
"name" file handling moved from drivers to the core, which added some
crazy checks what name can contain. Even if this "works", what is the
expected effect on the "name" file?
Documentation/hwmon/sysfs-interface. Is enforcing that 'crazy' ?
Maybe in your world, but not in mine.
Well, lets revert the patch and then we can discuss what to do with
the "name" problem.
Ok, so the patch is on the way in. What to do next?
pavel@n900:/sys/class/hwmon$ cat hwmon0/name
pavel@n900:/sys/class/hwmon$ cat hwmon1/name
The 'name' parameter will be mandatory for hwmon_device_register_with_groups()
and hwmon_device_register_with_info() starting with v4.11, and the API
documentation will be updated to list all invalid characters.
The thermal subsystem doesn't play well when it comes to hwmon userspace
interaction (generating and removing sensor attributes dynamically
messes up pretty much everything, and generating the name attribute after
hwmon registration for sure messes up any udev listener). libsensors gets
confused by '-' in the 'name' attribute. libsensors also doesn't expect
sensor attributes to be dynamically generated and removed, and may
react unpredictably if they are. This all means that any existing users
of hwmon devices created by the thermal subsystem will most likely not
use libsensors nor udev listeners. At the same time, it seems to be quite
important at least to you that the '-' in the name is retained.
Given all that, maybe thermal should just stick with the deprecated API
and accept the deprecated warning message (or maybe drop hwmon support