Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64
From: Will Deacon
Date: Wed Jan 25 2017 - 08:32:19 EST
On Wed, Jan 25, 2017 at 07:23:11AM +0000, He Kuang wrote:
> Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> regs_query_register_offset() to convert register name to offset for
> arm64, so the BPF prologue feature is ready to use.
> This patch also changes the 'dwarfnum' to 'offset' in register table,
> so the related functions are consistent with x86.
Wouldn't it be an awful lot simpler just to leave the code as-is, and
implement regs_query_register_offset in the same way that we implement
get_arch_regstr but return the dwarfnum?
I don't really see the point of all the refactoring.