Re: [PATCH] drm/amd/powerplay: header should be defining _SMU7_CLOCK_POWER_GATING_H_

[Alex Deucher]

On Wed, Jan 25, 2017 at 7:07 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> _SMU7_CLOCK_POWER_GATING_H_ is being used as a header guard, followed by
> a #define of a different macro.  Define _SMU7_CLOCK_POWER_GATING_H_ instead
> to fix this.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks for the patch.  Nicolas beat you to it:
https://lists.freedesktop.org/archives/dri-devel/2017-January/130477.html


Alex

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> index d52a28c..c96ed9e 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.h
> @@ -22,7 +22,7 @@
>   */
>
>  #ifndef _SMU7_CLOCK_POWER_GATING_H_
> -#define _SMU7_CLOCK__POWER_GATING_H_
> +#define _SMU7_CLOCK_POWER_GATING_H_
>
>  #include "smu7_hwmgr.h"
>  #include "pp_asicblocks.h"
> --
> 2.10.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel