Re: [PATCH 0/2] dmaengine: Add DW AXI DMAC driver

[Andy Shevchenko]

On Wed, 2017-01-25 at 18:34 +0300, Eugeniy Paltsev wrote:
> This patch series add support for the DW AXI DMAC controller.
> 
> DW AXI DMAC is a part of upcoming development board from Synopsys.
> 
> In this driver implementation only DMA_MEMCPY and DMA_SG transfers
> are supported.
> 
> Changes for v0:
> Â* Switch to virt-dma API (according to previous RFC)
> Â* Small fixies according to previous RFC

Yeah, seems you didn't address some of the comments and didn't comment
why...

> Â* Add DT bindings
> 
> Eugeniy Paltsev (2):
> Â dt-bindings: Document the Synopsys DW AXI DMA bindings
> Â dmaengine: Add DW AXI DMAC driver
> 
> Â.../devicetree/bindings/dma/snps,axi-dw-dmac.txtÂÂÂ|ÂÂÂ33 +
> Âdrivers/dma/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ8 +
> Âdrivers/dma/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ1 +

> Âdrivers/dma/axi_dma_platform.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 1060
> ++++++++++++++++++++

This surprises me. I would expect more then 100+ LOC reduction when
switched to virt-dma API. Can you double check that you are using it
effectively?

> Âdrivers/dma/axi_dma_platform.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ124 +++
> Âdrivers/dma/axi_dma_platform_reg.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ189 ++++
> Â6 files changed, 1415 insertions(+)
> Âcreate mode 100644 Documentation/devicetree/bindings/dma/snps,axi-dw-
> dmac.txt
> Âcreate mode 100644 drivers/dma/axi_dma_platform.c
> Âcreate mode 100644 drivers/dma/axi_dma_platform.h
> Âcreate mode 100644 drivers/dma/axi_dma_platform_reg.h
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy