Re: [PATCH v3] i2c: core: helper function to detect slave mode
From: Wolfram Sang
Date: Wed Jan 25 2017 - 15:45:51 EST
> + * i2c_slave_mode_detect - detect operation mode
I'd rather name it 'i2c_detect_slave_mode'
> + * @dev: The device owning the bus
> + *
> + * This checks the device nodes for an I2C slave by checking the address
> + * used.
> + *
> + * Returns true if an I2C slave is detected, otherwise returns false.
Both paragraphs could be a little more explicit. It is not about
"slaves" or "clients" in general, but about those entries which make the
current master act as a slave, too.
The code looks good to me, so we are close to go!
Description: PGP signature