Re: [PATCH 0/6 v3] kvmalloc
From: Michal Hocko
Date: Thu Jan 26 2017 - 07:27:38 EST
On Thu 26-01-17 04:14:37, Joe Perches wrote:
> On Thu, 2017-01-26 at 11:32 +0100, Michal Hocko wrote:
> > So I have folded the following to the patch 1. It is in line with
> > kvmalloc and hopefully at least tell more than the current code.
> > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > @@ -1741,6 +1741,13 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
> > * Allocate enough pages to cover @size from the page level
> > * allocator with @gfp_mask flags. Map them into contiguous
> > * kernel virtual space, using a pagetable protection of @prot.
> > + *
> > + * Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_REPEAT
> > + * and __GFP_NOFAIL are not supported
> Maybe add a BUILD_BUG or a WARN_ON_ONCE to catch new occurrences?
I would really like to not touch vmalloc in this series.