Re: [PATCH 04/13] Input: keyboard - Use local variables consistently
From: Dmitry Torokhov
Date: Thu Jan 26 2017 - 13:59:46 EST
On Thu, Jan 26, 2017 at 2:31 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>> If a function declares a variable to access a structure element,
>> use it conssistently.
> Weird spelling :)
>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>> - error = devm_gpio_request_one(&pdev->dev, button->gpio, flags,
>> - desc);
>> + error = devm_gpio_request_one(dev, button->gpio, flags, desc);
> I think I have changes in the GPIO tree touching these code sites.
> I put those on an immutable branch so Dmitry can pull it if he needs
> it as a base for this patch:
I just tried it and it seems to merge cleanly even on top of Guenter's
patch so I think I do not have to pull it in, not yet at least.