Re: [char-misc-next V3] mei: simplify error handling via devres function.

From: Greg Kroah-Hartman
Date: Fri Jan 27 2017 - 03:15:08 EST

On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote:
> Use devm_ and pcim_ functions to make error handling
> simpler and code smaller and tidier.
> Based on original patch by
> mei: me: use managed functions pcim_* and devm_*
> Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> V2: Thanks Andy for review, integratd changes:
> 1. Rename devm_mei_me_init back to mei_me_dev_init
> they don't really belong to devm_ namespace.
> 2. Revert pcim irq reservation change.
> 3. Drop setting driver data to NULL on exit.
> 4. Use directly mmio pointer received from pcim_iomap_table
> V3: Remove pci_disable_msi, it is also handled by the system.

Andy, any objection to this version?


greg k-h