Re: [PATCH] Input: tegra-kbc - Fix possible NULL derefrence.

From: Thierry Reding
Date: Fri Jan 27 2017 - 06:05:33 EST

On Fri, Jan 27, 2017 at 04:12:36PM +0530, Shailendra Verma wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
> Signed-off-by: Shailendra Verma <shailendra.v@xxxxxxxxxxx>
> ---
> drivers/input/keyboard/tegra-kbc.c | 5 +++++
> 1 file changed, 5 insertions(+)

I think that's rather pointless. The driver is OF-only, so the only way
it will bind to a device is if the device's compatible matches one of
the entries in the tegra_kbc_of_match table, in which case match will
never be NULL.


Attachment: signature.asc
Description: PGP signature