Re: [PATCH v2] PCI: exynos: refactor exynos pcie driver
From: Bjorn Helgaas
Date: Sat Jan 28 2017 - 16:29:38 EST
On Thu, Jan 05, 2017 at 09:23:38AM +0530, Pankaj Dubey wrote:
> From: Niyas Ahmed S T <niyas.ahmed@xxxxxxxxxxx>
> Currently Exynos PCIe driver is only supported for Exynos5440 SoC.
> This patch does refactoring of Exynos PCIe driver to extend support
> for other Exynos SoC.
> Following are the main changes done via this patch:
> 1) It adds separate structs for memory, clock resources.
> Reason behind this change is, moving ahead various Exynos SoC will
> have different hardware resources such as iomem, clocks, regmap handles
> etc. for PCIe controller, so keeping these resources in separate struct
> will help us in intiailizing them via per SoC ops, and will avoid too
> many of_machine_is_compatible in code, and help us simplifying
> exynos_pcie struct.
> 2) It add exynos_pcie_ops struct which will allow us to support the
> differences in resources in different Exynos SoC.
> No functional change intended.
> Signed-off-by: Niyas Ahmed S T <niyas.ahmed@xxxxxxxxxxx>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> This patch set is prepared on top of Krzysztof's for-next and
> PCIe driver cleanup patch  by Jaehoon Chung.
> : https://lkml.org/lkml/2016/12/19/44
Jaehoon has posted an updated version since you posted this patch, so
I assume this will need to be rebased on that. I'll drop this version and
wait for your rebased version.