Re: [PATCH] I2c: busses - Fix possible NULL derefrence.
From: Uwe Kleine-König
Date: Mon Jan 30 2017 - 03:26:55 EST
On Mon, Jan 30, 2017 at 08:12:17AM +0100, Thierry Reding wrote:
> On Mon, Jan 30, 2017 at 10:33:07AM +0530, Shailendra Verma wrote:
> > of_device_get_match_data could return NULL, and so can cause
> > a NULL pointer dereference later.
> > Signed-off-by: Shailendra Verma <shailendra.v@xxxxxxxxxxx>
> > ---
> > drivers/i2c/busses/i2c-tegra.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> This will never happen. Any match in the OF table that would cause the
> ->probe() to occur has a valid .data pointer associated with it.
Theoretically you could (I think) bind that driver to a node with
compatible = "tegra-i2c";
Anyhow, even if today there was no possibility this could happen, that's
something that might easily be changed by a future change. So I doubt
"this will never happen" stays true for sure and being defensive is a
good idea. And even a BUG would be better than a silent NULL pointer
Just my â 0.02
Pengutronix e.K. | Uwe Kleine-KÃnig |
Industrial Linux Solutions | http://www.pengutronix.de/ |