Re: [PATCH V6 3/5] OF: Add missing I/O range exception for indirect-IO devices

From: John Garry
Date: Mon Jan 30 2017 - 04:05:14 EST

On 27/01/2017 22:03, Rob Herring wrote:
On Tue, Jan 24, 2017 at 03:05:23PM +0800, zhichang.yuan wrote:
There are some special ISA/LPC devices that work on a specific I/O range where
it is not correct to specify a 'ranges' property in DTS parent node as cpu
addresses translated from DTS node are only for memory space on some
architectures, such as Arm64. Without the parent 'ranges' property, current
of_translate_address() return an error.
Here we add special handlings for this case.
During the OF address translation, some checkings will be perfromed to
identify whether the device node is registered as indirect-IO. If yes, the I/O
translation will be done in a different way from that one of PCI MMIO.
In this way, the I/O 'reg' property of the special ISA/LPC devices will be
parsed correctly.

Signed-off-by: zhichang.yuan <yuanzhichang@xxxxxxxxxxxxx>
Signed-off-by: Gabriele Paoloni <gabriele.paoloni@xxxxxxxxxx>
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Shouldn't this be Reviewed-by?

The background is that Zhichang is following a sketch of a re-worked driver from Arnd, which Arnd gave Signed-off-by. But this patch does not follow it verbatim.

I think this patchset should be resent without Arnd's signature. Or Arnd may kindly review and say it's ok.


Otherwise, looks fine to me.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

drivers/of/address.c | 87 ++++++++++++++++++++++++++++++++++++++++++----------
1 file changed, 71 insertions(+), 16 deletions(-)