Re: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
From: Alexander Kochetkov
Date: Mon Jan 30 2017 - 08:55:49 EST
> 30 ÑÐÐ. 2017 Ð., Ð 16:12, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> ÐÐÐÐÑÐÐ(Ð):
> I don't get the point of these changes. The patch does not explain why they are
Iâd like to extract timer API from current implementation.
And to make code more readable Iâd like to introduce 'struct rk_timerâ what can be
reused with current implementation and with my patch (8/8). And in order keep patches
simple and readable I split that into three patches: 5/8, 6/8, 7/8.
Current implementation named rockchip timer as âstruct bc_timerâ (broadcast timer).
I renamed it to more suitable to it role (may be bad choice).
Yes, the patch itself looks strange. You are right.
What do you think about that solution:
- in the patch 6/8 i will Introduce 'struct rk_timerâ and 'struct rk_time_clkevtâ (renamed âstruct bc_timerâ).
- rk_timer_init() changes from 5/8 I will merge with 8/8
- 8/8 introduce 'struct rk_time_clksrc'
- 5/8 drop