Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

From: Borislav Petkov
Date: Mon Jan 30 2017 - 10:32:58 EST

On Mon, Jan 30, 2017 at 02:51:51PM +0000, Russell King - ARM Linux wrote:
> Like it or not, it is _already_ exported to userspace, so it forms

Well, I did try to stop it then too:

b72e7464e4cf ("x86/uapi: Do not export <asm/msr-index.h> as part of the user API headers")

And yet this wankery trickled out to userspace anyway.

> part of the user ABI. You can try to remove it from userspace view,
> but if anyone has already started to use it, removing it will already
> cause a userspace regression.

Well, if it were me, I'd still remove the header and see if anything

If it does - which I doubt very much - we can do Christoph's idea of
leaving the current version of the header exported but then untangling
it from the whole uapi crap and use our own kernel version which we can
change as much as we can.

In the end of the day, it is a maintainer decision what's going to


Good mailing practices for 400: avoid top-posting and trim the reply.