Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined
From: Michal Hocko
Date: Mon Jan 30 2017 - 10:53:46 EST
On Mon 30-01-17 22:59:52, Yisheng Xie wrote:
> Hiï Michalï
> Sorry for late reply.
> On 01/26/2017 05:18 PM, Michal Hocko wrote:
> > On Wed 25-01-17 23:05:37, ysxie@xxxxxxxxxxx wrote:
> >> From: Yisheng Xie <xieyisheng1@xxxxxxxxxx>
> >> Define isolate_movable_page as a static inline function when
> >> CONFIG_MIGRATION is not enable. It should return false
> >> here which means failed to isolate movable pages.
> >> This patch do not have any functional change but prepare for
> >> later patch.
> > I think it would make more sense to make isolate_movable_page return int
> > and have the same semantic as __isolate_lru_page. This would be a better
> > preparatory patch for the later work.
> Yes, I think you are right, it is better to make isolate_movable_page return int
> just as what isolate_lru_page do, to make a better code style.
> It seems Andrew had already merged the fixed patch from Arnd Bergmann,
> Maybe I can rewrite it in a later patch if it is suitable :)
I guess Andrew can just drop the current series with the folow up fixes
and wait for your newer version.