On Mon 30 Jan 07:03 PST 2017, Avaneesh Kumar Dwivedi wrote:Thanks Bjorn, but please look below inline comment.
This patch add additional clock and regulator resource which areApplied, with below modification.
initialized based on compatible and has no impact on existing driver
working. This resourse addition enable the existing driver to handle.
low pass sensor processor device also.
Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx>
I observed that giving "cx" or "px" string to devm_regulator_get() was returning with dummy regulator, and if i gave "vdd_cx" and "vdd_px" it did not print dummy regulator warning.---[..]
drivers/remoteproc/qcom_adsp_pil.c | 43 +++++++++++++++++++++++++++++++-------
1 file changed, 36 insertions(+), 7 deletions(-)
diff --git a/drivers/remoteproc/qcom_adsp_pil.c b/drivers/remoteproc/qcom_adsp_pil.c
static int adsp_init_regulator(struct qcom_adsp *adsp)We should not change the name of devicetree properties, so I dropped
- adsp->cx_supply = devm_regulator_get(adsp->dev, "cx");
+ adsp->cx_supply = devm_regulator_get(adsp->dev, "vdd_cx");
"vdd_" on both of these.
+ adsp->px_supply = devm_regulator_get(adsp->dev, "vdd_px");
+ if (IS_ERR(adsp->px_supply))
+ return PTR_ERR(adsp->px_supply);