Re: [PATCH v3 2/4] remoteproc: qcom: Add additional agree2_clk and px regulator resource.

From: Dwivedi, Avaneesh Kumar (avani)
Date: Tue Jan 31 2017 - 01:07:55 EST

On 1/31/2017 3:16 AM, Bjorn Andersson wrote:
On Mon 30 Jan 07:03 PST 2017, Avaneesh Kumar Dwivedi wrote:

This patch add additional clock and regulator resource which are
initialized based on compatible and has no impact on existing driver
working. This resourse addition enable the existing driver to handle.
low pass sensor processor device also.

Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx>
Applied, with below modification.
Thanks Bjorn, but please look below inline comment.
drivers/remoteproc/qcom_adsp_pil.c | 43 +++++++++++++++++++++++++++++++-------
1 file changed, 36 insertions(+), 7 deletions(-)

diff --git a/drivers/remoteproc/qcom_adsp_pil.c b/drivers/remoteproc/qcom_adsp_pil.c
static int adsp_init_regulator(struct qcom_adsp *adsp)
- adsp->cx_supply = devm_regulator_get(adsp->dev, "cx");
+ adsp->cx_supply = devm_regulator_get(adsp->dev, "vdd_cx");
We should not change the name of devicetree properties, so I dropped
"vdd_" on both of these.
I observed that giving "cx" or "px" string to devm_regulator_get() was returning with dummy regulator, and if i gave "vdd_cx" and "vdd_px" it did not print dummy regulator warning.
in device tree these regulators node were defined as "vdd_cx-supply" and "vdd_px-supply"

if (IS_ERR(adsp->cx_supply))
return PTR_ERR(adsp->cx_supply);
regulator_set_load(adsp->cx_supply, 100000);
+ adsp->px_supply = devm_regulator_get(adsp->dev, "vdd_px");
+ if (IS_ERR(adsp->px_supply))
+ return PTR_ERR(adsp->px_supply);

Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.