Re: [PATCH 01/14] locking/atomic: import atomic_dec_not_zero()

[Ingo Molnar]

* Fabian Frederick <fabf@xxxxxxxxx> wrote:

> complementary definition to atomic_inc_not_zero() featured in
> lib/fault-inject.c
> 
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
>  include/linux/atomic.h | 2 ++
>  lib/fault-inject.c     | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/atomic.h b/include/linux/atomic.h
> index e71835b..d8e6551 100644
> --- a/include/linux/atomic.h
> +++ b/include/linux/atomic.h
> @@ -517,6 +517,8 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u)
>  #define atomic_inc_not_zero(v)		atomic_add_unless((v), 1, 0)
>  #endif
>  
> +#define atomic_dec_not_zero(v)          atomic_add_unless((v), -1, 0)
> +
>  #ifndef atomic_andnot
>  static inline void atomic_andnot(int i, atomic_t *v)
>  {
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index 6a823a5..4ad5dcc 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -52,8 +52,6 @@ static void fail_dump(struct fault_attr *attr)
>  	}
>  }
>  
> -#define atomic_dec_not_zero(v)		atomic_add_unless((v), -1, 0)
> -

Why did you convert the tabs to spaces?

Thanks,

	Ingo