Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

From: Ursula Braun
Date: Tue Jan 31 2017 - 06:28:52 EST


ACK - compile-tested successfully on s390.

On 01/30/2017 07:47 PM, Fabian Frederick wrote:
> instead of atomic_add_unless(value, -1, 0)
>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
> ---
> drivers/s390/net/qeth_core_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 315d8a2..9595b90 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3278,7 +3278,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index)
> atomic_set(&card->force_alloc_skb, 3);
> count = newcount;
> } else {
> - atomic_add_unless(&card->force_alloc_skb, -1, 0);
> + atomic_dec_not_zero(&card->force_alloc_skb);
> }
>
> if (!count) {
>