Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver
From: Linus Walleij
Date: Tue Jan 31 2017 - 09:21:07 EST
Forgot to mention this:
On Wed, Jan 25, 2017 at 7:51 PM, Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote:
> This driver handles the GPIOs of all the Ingenic JZ47xx SoCs
> currently supported by the upsteam Linux kernel.
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> + jzgc->gc.base = -1;
> + of_property_read_u32(dev->of_node, "base", &jzgc->gc.base);
Remove this. Dynamic allocation should be fine, if you're using the
new userspace ABI like tools/gpio/* or libgpiod and only that and in-kernel
consumers, dynamic numbers are just fine.
If you have old sysfs userspace that you need to support using the
global GPIO numberspace, please look into ways to phase that out.