Re: [PATCH 1/1] MicroSemi Switchtec management interface driver
From: Logan Gunthorpe
Date: Tue Jan 31 2017 - 12:36:53 EST
On 31/01/17 10:26 AM, Greg Kroah-Hartman wrote:
> That's one big patch to review, would you want to do that?
Sorry, will do.
> Can you break it up into smaller parts? At least put the documentation
> separately, right?
Ha, funny. Last time I sent a patch someone asked for the documentation
to be in the same patch. But I can easily split this up.
> And don't dump a .txt file into Documentation/ anymore, people are
> working to move to the newer format.
Fair. I wasn't sure where a good place to put it was. Any suggestions?
> Also, please rebase against Linus's tree at the least, we can't go back
> in time and apply this to the 4.9 kernel tree.
> Why a .h file for a single .c file?
I wanted to keep the hardware defining structs and macros in a separate
file for future expansion. This hardware is also capable of some NTB
functions which may find it's way into the kernel in the future.
> Also, why a whole new directory?
We didn't feel it fit in the pci director which was for standard pci
stuff. We're more than open to other suggestions as to where this code