Re: [PATCH] net: thunderx: avoid dereferencing xcv when NULL

From: David Miller
Date: Tue Jan 31 2017 - 13:11:56 EST

From: Vincent Stehlé <vincent.stehle@xxxxxxxxxxx>
Date: Mon, 30 Jan 2017 15:06:43 +0100

> This fixes the following smatch and coccinelle warnings:
> drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch]
> drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle]
> Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support")
> Signed-off-by: Vincent Stehlé <vincent.stehle@xxxxxxxxxxx>
> Cc: Sunil Goutham <sgoutham@xxxxxxxxxx>

I've applied this, but wow this is some code that needs fixing on a more
fundamental level.

Having a global pointer for a device private and assuming only one instance
of a PCI device ID will ever be probe in a system is really wrong.

This is true even in all known machines or configurations this might
be true.

It leads to exactly the kinds of problems shown here.

Objects should be probed by instance, and if operations need to
be performed on it, a pointer to the software state for that object
instance should be passed around. Rather than having an implicit
single object.