Re: [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric

From: Greg KH
Date: Wed Feb 01 2017 - 03:06:16 EST


On Tue, Jan 31, 2017 at 06:19:16PM -0800, Stefan Agner wrote:
> Currently qw_sign requires UTF-8 character to set, but returns UTF-16
> when read. This isn't obvious when simply using cat since the null
> characters are not visible, but hexdump unveils the true string:
>
> # echo MSFT100 > os_desc/qw_sign
> # hexdump -C os_desc/qw_sign
> 00000000 4d 00 53 00 46 00 54 00 31 00 30 00 30 00 |M.S.F.T.1.0.0.|
>
> Make qw_sign symmetric by returning an UTF-8 string too. Also follow
> common convention and add a new line at the end.

Doesn't USB require that strings be in UTF-16? So why have the kernel
convert them?

thanks,

greg k-h