Re: [PATCH] x86, mpx: re-add MPX to selftests Makefile

[Ingo Molnar]

* Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> wrote:

> 
> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> 
> Ingo pointed out that the MPX tests were no longer in the selftests
> Makefile.  It appears that I shot myself in the foot on this one
> and accidentally removed them when I added the pkeys tests, probably
> from bungling a merge conflict.

Note, we still have these ugly warnings when building the pkeys testcase with GCC 
5.4.0:

gcc -m32 -o protection_keys_32 -O2 -g -std=gnu99 -pthread -Wall  protection_keys.c -lrt -ldl -lm
protection_keys.c: In function âsetup_hugetlbfsâ:
protection_keys.c:816:6: warning: unused variable âiâ [-Wunused-variable]
  int i;
      ^
protection_keys.c:815:6: warning: unused variable âvalidated_nr_pagesâ [-Wunused-variable]
  int validated_nr_pages;
      ^
protection_keys.c: In function âtest_pkey_syscalls_bad_argsâ:
protection_keys.c:1136:6: warning: unused variable âbad_flagâ [-Wunused-variable]
  int bad_flag = (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE) + 1;
      ^
protection_keys.c: In function âtest_pkey_alloc_exhaustâ:
protection_keys.c:1153:16: warning: unused variable âinit_valâ [-Wunused-variable]
  unsigned long init_val;
                ^
protection_keys.c:1152:16: warning: unused variable âflagsâ [-Wunused-variable]
  unsigned long flags;
                ^
In file included from protection_keys.c:45:0:
pkey-helpers.h: In function âsigsafe_printfâ:
pkey-helpers.h:41:3: warning: ignoring return value of âwriteâ, declared with attribute warn_unused_result [-Wunused-result]
   write(1, dprint_in_signal_buffer, len);
   ^
protection_keys.c: In function âdumpitâ:
protection_keys.c:407:3: warning: ignoring return value of âwriteâ, declared with attribute warn_unused_result [-Wunused-result]
   write(1, buf, nr_read);
   ^
protection_keys.c: In function âpkey_disable_setâ:
protection_keys.c:68:5: warning: âorig_pkruâ may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (!(condition)) {   \
     ^
protection_keys.c:465:6: note: âorig_pkruâ was declared here
  u32 orig_pkru;
      ^

Thanks,

	Ingo