Re: [PATCH 1/2] gpio: Rename devm_get_gpiod_from_child()

[Boris Brezillon]

On Thu, 2 Feb 2017 11:53:17 +0100
Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> On Mon, Jan 30, 2017 at 4:41 PM, Boris Brezillon
> <boris.brezillon@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > Rename devm_get_gpiod_from_child() into
> > devm_fwnode_get_gpiod_from_child() to reflect the fact that this
> > function is operating on a fwnode object.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>  
> 
> All right! So we settled we're gonna merge this and the other patch and
> we have the necessary ACKs.
> 
> This is unfortunately not applying because I have a bunch of other patches
> touching the same files (that's why I think it's a good opportunity to
> rename it now, as mentioned IIRC).
> 
> Could you rebase this on the following branch:
> https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=ib-gpiod-flags

While rebasing I noticed that you forgot to add the label parameter to
the kernel doc header in commit b2987d7438e0 ("gpio: Pass GPIO label
down to gpiod_request").

> 
> Then I will apply it on top of that immutable branch and pull it into the
> devel branch of gpio so that we get it in and also have an immutable
> branch with all changes if some other subsystem maintainer needs it
> because of clashes.
> 
> Yours,
> Linus Walleij