Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

From: Jon Mason
Date: Thu Feb 02 2017 - 13:13:33 EST


On Wed, Feb 1, 2017 at 6:12 PM, RafaÅ MiÅecki <rafal@xxxxxxxxxx> wrote:
> On 02/01/2017 11:39 PM, Jon Mason wrote:
>>
>> From: Hari Vyas <hariv@xxxxxxxxxxxx>
>>
>> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
>> bgmac_set_mac_address() but code assumed u8 *. This caused two bytes
>> chopping and the wrong mac address was configured.
>>
>> Signed-off-by: Hari Vyas <hariv@xxxxxxxxxxxx>
>> Signed-off-by: Jon Mason <jon.mason@xxxxxxxxxxxx>
>> Fixes: 4e209001b86 ("bgmac: write mac address to hardware in
>> ndo_set_mac_address")
>
>
> Sounds OK, would it make sense to Cc stable?

Sure, I'll add Sergei's mods and do a v2 with stable on the Cc list