Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

From: Pavel Machek
Date: Fri Feb 03 2017 - 05:47:53 EST


On Fri 2016-12-09 12:49:33, Andrejczuk, Grzegorz wrote:
> > > On Thu 2016-10-27 16:38:13, Thomas Gleixner wrote:
> > > > On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> > > > > +#ifdef CONFIG_X86_64
> > > > > +static int phi_r3mwait_disabled __read_mostly;
> > > > > +
> > > > > +static int __init phir3mwait_disable(char *__unused) {
> > > > > + phi_r3mwait_disabled = 1;
> > > > > + pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");
> > > >
> > > > Why would that be a warning? The sysadmin added the command line
> > > > switch, so why does he needs to be warned?
> > >
> > > Its telling admin he did not make a typo on the command line. We often do that....
> >
> > Definitely not at the warning level.
>
> Is info level OK for that message?

I'd say so.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature