Re: [PATCH] Drivers: staging: speakup: spk_priv.h - style fix

From: Derek Robson
Date: Fri Feb 03 2017 - 22:32:45 EST


On Sat, Feb 04, 2017 at 10:41:20AM +0800, kbuild test robot wrote:
> Hi Derek,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on v4.10-rc6 next-20170203]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Derek-Robson/Drivers-staging-speakup-spk_priv-h-style-fix/20170204-080247
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All error/warnings (new ones prefixed by >>):
>
> #define param_check_int(name, p) __param_check(name, p, int)
> ^~~~~~~~~~~~~
> include/linux/moduleparam.h:146:2: note: in expansion of macro 'param_check_int'
> param_check_##type(name, &(value)); \
> ^~~~~~~~~~~~
> drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> module_param_named(ser, synth_acntsa.ser, int, 0444);
> ^~~~~~~~~~~~~~~~~~
> include/linux/moduleparam.h:146:36: error: expected declaration specifiers before ';' token
> param_check_##type(name, &(value)); \
> ^
> drivers/staging/speakup/speakup_acntsa.c:136:1: note: in expansion of macro 'module_param_named'
> module_param_named(ser, synth_acntsa.ser, int, 0444);
> ^~~~~~~~~~~~~~~~~~
> include/linux/moduleparam.h:220:20: error: storage class specified for parameter '__param_str_ser'
> static const char __param_str_##name[] = prefix #name; \

Can anyone tell me what I did wrong?
I don't think it was my patch that broke the build.

Thanks