Re: [sched/clock] 9881b024b7: WARNING:at_kernel/sched/clock.c:#set_sched_clock_stable

[Ye Xiaolong]

On 01/26, Peter Zijlstra wrote:
>On Thu, Jan 26, 2017 at 05:14:06AM +0800, kernel test robot wrote:
>> 
>> FYI, we noticed the following commit:
>> 
>> commit: 9881b024b7d7671f6a014091bc96506b89081802 ("sched/clock: Delay switching sched_clock to stable")
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> 
>
>> [ 1457.700884] 
>> [ 1457.701518] masked ExtINT on CPU#1
>> [ 1457.701523] ------------[ cut here ]------------
>> [ 1457.701527] WARNING: CPU: 1 PID: 0 at kernel/sched/clock.c:114 set_sched_clock_stable+0x66/0x70
>> [ 1457.701527] Modules linked in: rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver netconsole sr_mod cdrom sg intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul crc32c_intel snd_hda_codec_realtek ghash_clmulni_intel ppdev mxm_wmi pcbc snd_hda_codec_generic aesni_intel crypto_simd glue_helper cryptd pcspkr ahci libahci firewire_ohci libata snd_hda_intel firewire_core crc_itu_t snd_hda_codec snd_hda_core snd_hwdep snd_pcm snd_timer snd soundcore i7core_edac edac_core shpchp winbond_cir rc_core floppy parport_pc parport wmi acpi_cpufreq ip_tables
>> [ 1457.701544] CPU: 1 PID: 0 Comm: swapper/1 Tainted: G        W I     4.10.0-rc3-00259-g9881b02 #1
>> [ 1457.701544] Hardware name:                  /DX58SO, BIOS SOX5810J.86A.4934.2010.0129.1220 01/29/2010
>> [ 1457.701545] Call Trace:
>> [ 1457.701549]  dump_stack+0x63/0x8a
>> [ 1457.701550]  __warn+0xcb/0xf0
>> [ 1457.701551]  warn_slowpath_null+0x1d/0x20
>> 
>
>Please do _NOT_ truncate WARNs, they have nice start and end markers for
>a purpose.

Thanks for the reminder, we've improved 0day robot's logic to show the whole call trace instead. 

Thanks,
Xiaolong
>
>In any case, this should be fixed by commit: acb04058de49 ("sched/clock: Fix hotplug crash")