Re: [PATCH v3 1/7] drm: Add DRM support for tiny LCD displays

[Jani Nikula]

On Tue, 31 Jan 2017, Noralf TrÃnnes <noralf@xxxxxxxxxxx> wrote:
> +const struct file_operations tinydrm_fops = {
> +	.owner		= THIS_MODULE,
> +	.open		= drm_open,
> +	.release	= drm_release,
> +	.unlocked_ioctl	= drm_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl	= drm_compat_ioctl,
> +#endif

No need for the ifdefs, drm_compat_ioctl will be defined NULL for
CONFIG_COMPAT=n.

BR,
Jani.


> +	.poll		= drm_poll,
> +	.read		= drm_read,
> +	.llseek		= no_llseek,
> +	.mmap		= drm_gem_cma_mmap,
> +};
> +EXPORT_SYMBOL(tinydrm_fops);

-- 
Jani Nikula, Intel Open Source Technology Center