Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly non-modular

[Viresh Kumar]

On 06-02-17, 03:03, Paul Gortmaker wrote:
> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
> 
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get the exact same change, so they are handled in batch.
> 
> Changes are (1) use init.h header in place of module.h header,
> (2) delete module_exit related code, (3) delete MODULE_DEVICE_TABLE,
> and (4) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags.
> 
> None of these drivers were using module_init() so we don't have to
> worry about the init ordering getting changed with this commit.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE etc. tags since all that information
> is already contained at the top of each file in the comments.
> 
> Cc: Viresh Kumar <vireshk@xxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: spear-devel@xxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/spear/pinctrl-plgpio.c    |  7 +------
>  drivers/pinctrl/spear/pinctrl-spear1310.c | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear1340.c | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear300.c  | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear310.c  | 12 ------------
>  drivers/pinctrl/spear/pinctrl-spear320.c  | 12 ------------
>  6 files changed, 1 insertion(+), 66 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh