Re: [PATCH v2 2/8] mmc: bcm2835: Add new driver for the sdhost controller.

[Gerd Hoffmann]

On Mo, 2017-02-06 at 21:34 +0100, Stefan Wahren wrote:
> Hi Gerd,
> 
> first of all here my wishlist for the next round of this driver:
> * compile test the series with ARM and ARM64

It is tested on both arm and arm64 (rpi2 + rpi3).

> * add me in CC for all patches of the series

Oops.  /me should be more careful when reading names.  I thought I had
you on Cc:  Double-checked.  Turned out that was Stephen Warren ...

> * run checkpatch.pl before submission

Hmm?  Are there any issues?  /me has a pre-commit hook running
checkpatch to avoid anything slipping though.

> * apply the patch series to your cgit repo

Branch pushed now: bcm2837-sdhost-squashed-v2

> > The sdhci controller supports both sdcard and sdio.  The sdhost
> > controller supports the sdcard only, but has better performance.  Also
> 
> Sorry, for the confusion. I was wrong. According to the registers the SDHOST should also support SDIO. It's a feature we could implement later.

Ok.

> > note that the rpi3 has sdio wifi, so driving the sdcard with the sdhost
> > controller allows to use the sdhci controller for wifi support.
> > 
> > The configuration is done by devicetree via pin muxing.  Both SD
> > controller are available on the same pins (2 pin groups = pin 22 to 27 +
> > pin 48 to 53).  So it's possible to use both SD controllers at the same
> > time with different pin groups.
> > 
> > The code was originally written by Phil Elwell in the downstream
> > Rasbperry Pi tree, and I did a major cleanup on it (+319, -707 lines
> > out of the original 2055) for inclusion.
> 
> I think it would be helpful to known the downstream commit, because this commit [1]
> doesn't seem to be included.
> 
> [1] - https://github.com/raspberrypi/linux/commit/ea4b1c5c2ddbb6caba43ab9b0103542a4ca7e1f0
> 
> I've found and fixed a lot of issues in this version and i think it would be better if i send you the patches for squashing them all together. Here is the preview for my patch series:
> 
> Stefan Wahren (15):
>   mmc: bcm2835: Add missing include for threaded irq
>   mmc: bcm2835: Remove CMD_DALLY_US
>   mmc: bcm2835: Fix pio_timeout handling
>   mmc: bcm2835: Remove unnecessary return in bcm2835_data_irq
>   mmc: bcm2835: Handle error cases during probe
>   mmc: bcm2835: Print clk_max as decimal
>   mmc: bcm2835: Downrate message in case of PIO fallback
>   mmc: bcm2835: Don't unveil the data pointer
>   mmc: bcm2835: remove unused host members
>   mmc: bcm2835: Avoid unnecessary linebreaks
>   mmc: bcm2835: Add leading zero to register dumps
>   mmc: bcm2835: Align struct members with tabs
>   mmc: bcm2835: Rearrange bcm2835_finish_request()
>   mmc: bcm2835: Rearrange bcm2835_dma_complete_work()
>   mmc: bcm2835: Rename Kconfig switch
> 
> I'll send it after my tests. In the following review i will mention only the issues which aren't fixed in my patch series.

I'll pick up the patches and look at the remaining issues, new version
later this week (i hope).

thanks,
  Gerd