Re: [PATCH 3/7] efi: Add SHIM and image security database GUID definitions

[Ard Biesheuvel]

On 7 February 2017 at 07:52, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
>
>> From: David Howells <dhowells@xxxxxxxxxx>
>>
>> Add the definitions for shim and image security database, both of which
>> are used widely in various Linux distros.
>>
>> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
>> Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>
> That's not a valid SOB chain: the SOB of the author of the patch (David Howells)
> must come first.
>
> I changed it to:
>
>   Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
>   Acked-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>   Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
>   Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>
> Please holler if that's not OK.
>

Ah yes, thanks for spotting that.

OK with me