drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'

From: kbuild test robot
Date: Tue Feb 07 2017 - 05:02:47 EST

Next message: Michal Hocko: "Re: mm: deadlock between get_online_cpus/pcpu_alloc"
Previous message: Bartosz Golaszewski: "[PATCH] irqdesc: add memory managed version of irq_alloc_descs()"
Next in thread: Randy Dunlap: "Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Kalle,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd
commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move under broadcom vendor directory
date: 1 year, 3 months ago
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f
# save the attached .config to linux build tree
make.cross ARCH=mips

All errors (new ones prefixed by >>):

>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'
void brcmf_debugfs_init(void)
^~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:118:20: note: previous definition of 'brcmf_debugfs_init' was here
static inline void brcmf_debugfs_init(void)
^~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:65:6: error: redefinition of 'brcmf_debugfs_exit'
void brcmf_debugfs_exit(void)
^~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:121:20: note: previous definition of 'brcmf_debugfs_exit' was here
static inline void brcmf_debugfs_exit(void)
^~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:74:5: error: redefinition of 'brcmf_debug_attach'
int brcmf_debug_attach(struct brcmf_pub *drvr)
^~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:124:19: note: previous definition of 'brcmf_debug_attach' was here
static inline int brcmf_debug_attach(struct brcmf_pub *drvr)
^~~~~~~~~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debug_attach':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:81:6: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
drvr->dbgfs_dir = debugfs_create_dir(dev_name(dev), root_folder);
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:82:17: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
if (IS_ERR(drvr->dbgfs_dir))
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:83:22: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
return PTR_ERR(drvr->dbgfs_dir);
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:90:6: error: redefinition of 'brcmf_debug_detach'
void brcmf_debug_detach(struct brcmf_pub *drvr)
^~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:128:20: note: previous definition of 'brcmf_debug_detach' was here
static inline void brcmf_debug_detach(struct brcmf_pub *drvr)
^~~~~~~~~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debug_detach':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:94:26: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:95:32: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
debugfs_remove_recursive(drvr->dbgfs_dir);
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_get_devdir':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:100:13: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
return drvr->dbgfs_dir;
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: At top level:
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:103:5: error: redefinition of 'brcmf_debugfs_add_entry'
int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/bus.h:20:0,
from drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:24:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:132:5: note: previous definition of 'brcmf_debugfs_add_entry' was here
int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_add_entry':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:109:10: error: 'struct brcmf_pub' has no member named 'dbgfs_dir'
drvr->dbgfs_dir, read_fn);
^~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c: In function 'brcmf_debugfs_get_devdir':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:101:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

vim +/brcmf_debugfs_init +58 drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c

ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 52 brcmf_dbg(TRACE, "enter: idx=%d\n", ifp->bssidx);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 53
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 54 return brcmf_debug_create_memdump(ifp->drvr->bus_if, data,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 55 evtmsg->datalen);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 56 }
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 57
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 @58 void brcmf_debugfs_init(void)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 59 {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 60 root_folder = debugfs_create_dir(KBUILD_MODNAME, NULL);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 61 if (IS_ERR(root_folder))
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 62 root_folder = NULL;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 63 }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 64
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 @65 void brcmf_debugfs_exit(void)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 66 {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 67 if (!root_folder)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 68 return;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 69
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 70 debugfs_remove_recursive(root_folder);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 71 root_folder = NULL;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 72 }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 73
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 @74 int brcmf_debug_attach(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 75 {
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05 76 struct device *dev = drvr->bus_if->dev;
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05 77
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 78 if (!root_folder)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 79 return -ENODEV;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 80
d9cb2596 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-12-05 @81 drvr->dbgfs_dir = debugfs_create_dir(dev_name(dev), root_folder);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 @82 if (IS_ERR(drvr->dbgfs_dir))
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 83 return PTR_ERR(drvr->dbgfs_dir);
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12 84
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 85
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 86 return brcmf_fweh_register(drvr, BRCMF_E_PSM_WATCHDOG,
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 87 brcmf_debug_psm_watchdog_notify);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 88 }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 89
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 @90 void brcmf_debug_detach(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 91 {
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 92 brcmf_fweh_unregister(drvr, BRCMF_E_PSM_WATCHDOG);
ff4445a8 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-10-08 93
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 94 if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 @95 debugfs_remove_recursive(drvr->dbgfs_dir);
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 96 }
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 97
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 98 struct dentry *brcmf_debugfs_get_devdir(struct brcmf_pub *drvr)
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 99 {
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 100 return drvr->dbgfs_dir;
d319a7cf drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 101 }
80969836 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 102
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12 @103 int brcmf_debugfs_add_entry(struct brcmf_pub *drvr, const char *fn,
82d957e0 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2014-07-12 104 int (*read_fn)(struct seq_file *seq, void *data))
80969836 drivers/net/wireless/brcm80211/brcmfmac/dhd_dbg.c Arend van Spriel 2012-06-09 105 {
5b18ffb2 drivers/net/wireless/brcm80211/brcmfmac/debug.c Arend van Spriel 2015-06-08 106 struct dentry *e;

:::::: The code at line 58 was first introduced by commit
:::::: d319a7cfd9d80a2e2359e978ba88991531312ee6 brcmfmac: add debugfs helper functions

:::::: TO: Arend van Spriel <arend@xxxxxxxxxxxx>
:::::: CC: John W. Linville <linville@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip

Next message: Michal Hocko: "Re: mm: deadlock between get_online_cpus/pcpu_alloc"
Previous message: Bartosz Golaszewski: "[PATCH] irqdesc: add memory managed version of irq_alloc_descs()"
Next in thread: Randy Dunlap: "Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]