Re: [PATCH] serial: sh-sci: Temporarily Revert "implement FIFO threshold register setting"

[Geert Uytterhoeven]

Hi Arnd,

On Tue, Feb 7, 2017 at 2:00 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> Patch the first three patches out of seven were applied, up to commit
> a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting"),
> which introduces a new helper function. This is not called until the next
> following patch, so we now get a build warning:
>
> drivers/tty/serial/sh-sci.c:977:12: error: 'scif_set_rtrg' defined but not used [-Werror=unused-function]
>
> The patch is good, but I think we should either apply the following patches
> as well, or revert this one to get a clean build.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> This is mainly a notification that I've applied the revert to my randconfig
> test tree, if you plan to merge the following patches for 4.11, we won't
> need this one.

The follow-up commits were added to tty/tty-next earlier today.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds