Re: [PATCH] mm/slub: Fix random_seq offset destruction

From: Andrew Morton
Date: Tue Feb 07 2017 - 16:49:59 EST


On Tue, 7 Feb 2017 07:41:13 -0800 Thomas Garnier <thgarnie@xxxxxxxxxx> wrote:

> On Tue, Feb 7, 2017 at 6:07 AM, Sean Rees <sean@xxxxxxxxxx> wrote:
> > Bailout early from init_cache_random_seq if s->random_seq is already
> > initialised. This prevents destroying the previously computed random_seq
> > offsets later in the function.
> >
> > If the offsets are destroyed, then shuffle_freelist will truncate
> > page->freelist to just the first object (orphaning the rest).
> >
> > This fixes https://bugzilla.kernel.org/show_bug.cgi?id=177551.
> >
> > Signed-off-by: Sean Rees <sean@xxxxxxxxxx>
>
> Please add:
>
> Fixes: 210e7a43fa90 ("mm: SLUB freelist randomization")

I also added

Reported-by: <userwithuid@xxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>