Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register operations for support sun6i.

From: Maxime Ripard
Date: Wed Feb 08 2017 - 04:10:38 EST


On Tue, Feb 07, 2017 at 08:50:43PM +0300, lis8215@xxxxxxxxx wrote:
> From: Siarhei Volkau <lis8215@xxxxxxxxx>
> This patch not introduce new features, just prepare code for
> adding sun6i PWM driver in next commits.
> A31 SoC have a different map of PWM registers than others ASoCs,
> but register bits purposes are very similar.
> This patch introduce set of register access routines, which
> are common for existing in driver ASoCs:
> - ctl_rdy - checks the ready bit of specified PWM channel,
> - ctl_read - reads value from control register of specified PWM channel,
> - ctl_write - writes significant bits to control register of specified PWM channel,
> - prd_read - reads value from period register of specified PWM channel,
> - prd_write - writes value to period register of specified PWM channel.
> Driver code redesigned to use the new routines.

Why don't you use regmap for that?


Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering

Attachment: signature.asc
Description: PGP signature