Re: [PATCH v2 06/16] net: stmmac: fix some code style problem

From: Joe Perches
Date: Wed Feb 08 2017 - 05:44:41 EST


On Wed, 2017-02-08 at 09:31 +0100, Corentin Labbe wrote:
> Checkpatch complains about some code style problem on stmmac_mdio.c.
> This patch fix them.
[]
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
[]
> @@ -258,6 +258,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> found = 0;
> for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
> struct phy_device *phydev = mdiobus_get_phy(new_bus, addr);
> +
> if (phydev) {
> int act = 0;
> char irq_num[4];

Maybe use
if (!phydev)
continue;
to reduce indentation