Re: [PATCH] staging: vc04_services: remove unused functions

From: Arnd Bergmann
Date: Wed Feb 08 2017 - 05:53:16 EST


On Tuesday, February 7, 2017 3:09:44 PM CET Dan Carpenter wrote:
> There is a bunch of vc04_services that we're still looking to merge in
> the near future. Please hold off deleting these until we are further
> along on that.
>

More generally speaking, I'd like to see all the
-Wmissing-declarations/-Wmissing-prototypes warnings addressed
in the kernel and turn on that warning by default.

If there are parts of vc04_services that are intentionally
left in place but currently unused, adding a declaration in the
header file with a comment should be sufficient to prevent it
from getting deleted or seeing bogus warnings.

Arnd