Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

From: Shanker Donthineni
Date: Wed Feb 08 2017 - 10:31:56 EST

Hi Marc,

In teardown path, code is still calling 'kfree(its->cmd_base)' to free memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ).

On 02/08/2017 08:43 AM, Robert Richter wrote:
On 08.02.17 14:41:18, Marc Zyngier wrote:
On Wed, Feb 01 2017 at 5:38:25 pm GMT, Robert Richter
<rrichter@xxxxxxxxxx> wrote:
The its command buffer must be page aligned, but kzalloc() is not
guaranteed to be (though it is mostly when allocating 64k). Use
__get_free_pages() as this is used for other buffers as well.

Signed-off-by: Robert Richter <rrichter@xxxxxxxxxx>
I'm still going through this series, but as this is an obvious fix, I've
cherry-picked it for 4.11.
That was actually my intention, thus I placed it first.


linux-arm-kernel mailing list

Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.