Re: [PATCH] serial: st-asc: Use new GPIOD API to obtain RTS pin

From: Andy Shevchenko
Date: Wed Feb 08 2017 - 14:44:42 EST


On Wed, 2017-02-08 at 18:47 +0100, Greg KH wrote:
> On Wed, Feb 08, 2017 at 06:31:10PM +0200, Andy Shevchenko wrote:
> > On Wed, 2017-02-08 at 21:48 +0800, kbuild test robot wrote:
> > > Hi Lee,
> > >
> > > [auto build test ERROR on tty/tty-testing]
> > > [cannot apply to v4.10-rc7 next-20170208]
> > > [if your patch is applied to the wrong git tree, please drop us a
> > > note
> > > to help improve the system]
> > >
> > > url:ÂÂÂÂhttps://github.com/0day-ci/linux/commits/Lee-Jones/serial-
> > > st-a
> > > sc-Use-new-GPIOD-API-to-obtain-RTS-pin/20170208-180609
> > > base:ÂÂÂhttps://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
> > > .git
> > > Âtty-testing
> > > config: x86_64-allmodconfig (attached as .config)
> > > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > > reproduce:
> > > ÂÂÂÂÂÂÂÂ# save the attached .config to linux build tree
> > > ÂÂÂÂÂÂÂÂmake ARCH=x86_64Â
> > >
> >
> > It requires to have immutable branch in one of the subsystem which
> > the
> > other one can pull.
>
> Which sucks, and is why you should not do api changes this way!

Not only me :-)

If above will not work we may do something like below for this cycle:

static inline ... devm_get_gpiod_from_child()
{
return devm_fwnode_get_gpiod_from_child(..., GPIO_AS_IS, "?");
}

in GPIO tree.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy