On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote:
On 02/08/2017 02:59 PM, Greg KH wrote:
On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote:
On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote:
From: Richard Leitner <dev@xxxxxxxxxx>
+#define DRIVER_NAME "usb251xb"
+#define DRIVER_DESC "Microchip USB 2.0 Hi-Speed Hub Controller"
+#define DRIVER_VERSION "1.0"
Is it my MUA, or all above indentations are broken?
What do you mean?
Should the strings be aligned, like the following?
#define DRIVER_NAME "usb251xb"
#define DRIVER_DESC "Microchip USB .."
#define DRIVER_VERSION "1.0"
Yep, tab vs. space indentation.
Above doesn't make much sense. Why not to use
I thought we already had functions to do this for you. Don't write
ones "by hand" either wya.
Which functions do you mean? I only found set_bit() and clear_bit()
atomic_ops. But those operate on "unsigned long" variables. From the
Native atomic bit operations are defined to operate
on objects aligned to the size of an "unsigned long"
C data type, and are least of that size.
__set_bit(), __clear_bit() -- non-atomic variants, but you are right,
that (unsigned long) exactly the point I didn't propose them.
+ /* the first data byte transferred tells the
+ * bytes will follow (byte count)
I'm not sure this is good formatted comment for USB subsystem.
Looks fine to me, why do you think it is incorrect?
I would do like
* The multi-line
Capital letter, period at the end, first empty line (unlike in net
+#else /* CONFIG_OF */
+static int usb251xb_get_ofdata(struct usb251xb *hub,
+ struct usb251xb_data *data)
+ return 0;
+#endif /* CONFIG_OF */
I don't think it's a good idea to have those ugly #ifdef.
How can it be removed?
__maybe_unused for function, device_property_*() instead of
Something like that. But if you are insisting this is *only* OF
available hardware or we don't care, I'll not object.