Re: [PATCH] Staging: comedi: drivers: comedi_test: Set max input value for auto config

From: Ian Abbott
Date: Thu Feb 09 2017 - 07:30:52 EST


On 27/01/17 15:55, Cheah Kok Cheong wrote:
Currently user can input any value for amplitude and period.
This patch set a sane max value for auto-configuration mode.

For manual configuration mode, it is assumed this is taken care of
by the COMEDI userspace tool since there's no limit set here from
day one in the staging tree. If otherwise then maybe this can be
looked at separately.

Signed-off-by: Cheah Kok Cheong <thrust73@xxxxxxxxx>

I don't think there is any need to limit these unless it results in arithmetic overflow, since they only affect the fake sample data values produced by the driver, not system performance.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-