Re: [PATCH 2/3] auxdisplay: ht16k33: rework input device initialization
From: Dmitry Torokhov
Date: Thu Feb 09 2017 - 13:11:33 EST
On Wed, Feb 08, 2017 at 05:48:02PM +0100, Robin van der Gracht wrote:
> On Tue, 31 Jan 2017 12:54:37 -0800
> Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> > +
> > + err = devm_request_threaded_irq(&client->dev, client->irq,
> > + NULL, ht16k33_keypad_irq_thread,
> > + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> > + DRIVER_NAME, keypad);
> I believe the interrupt trigger should be switched to IRQF_TRIGGER_HIGH
> combined with IRQF_ONESHOT, for this new setup. This is causing a race
> In the previous situation a 'key data' read was triggered by
> ht16k33_keypad_start(). This cleared the IRQ and gave a (somewhat racy)
> known state. Now, when the IRQ line is HIGH during probe keyscan
> wont work.
> Also, when ht16k33_keypad_stop() is run while the irq thread is waiting
> for debounce, the scan will be skipped and irq will never be cleared.
> This also breaks keyscan.
You are absolutely right, I shoudl have changed this to
IRQF_TRIGGER_HIGH. I'll resend updated patch series in a minute.