Re: [PATCH] i2c: designware: Fix regression when dynamic TAR update is disabled

[Andy Shevchenko]

On Fri, 2017-02-10 at 01:20 +0530, Shah Nehal-Bakulchandra wrote:
> The following commit causes a regression when dynamic TAR update is
> disabled:
> 
> ÂÂÂÂÂcommit 63d0f0a6952a1a02bc4f116b7da7c7887e46efa3 ("i2c:
> designware:
> ÂÂÂÂÂdetect when dynamic tar update is possible")

Please, leave just 12 characters, it still enough.

> In such case, the DW_IC_CON_10BITADDR_MASTER is R/W, and is changed
> by the logic that's trying to detectÂÂdynamic TAR update.The original
> value of DW_IC_CON_10BITADDR_MASTER bit should be restored.
> 

+ Fixes tag?

> Signed-off-by: Shah Nehal-Bakulchandra <Nehal-
> bakulchandra.Shah@xxxxxxx>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> ---
> Âdrivers/i2c/busses/i2c-designware-core.c | 5 +++++
> Â1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-core.c
> b/drivers/i2c/busses/i2c-designware-core.c
> index 6d81c56..0c57166 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -987,6 +987,11 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
> Â	ÂÂÂÂ(reg & DW_IC_CON_10BITADDR_MASTER)) {
> Â		dev->dynamic_tar_update_enabled = true;
> Â		dev_dbg(dev->dev, "Dynamic TAR update enabled");
> +	} else {
> +		/* If test is failed then restore the original value
> */

> +		dev->dynamic_tar_update_enabled = false;

It's default.

> +		dev_dbg(dev->dev, "Dynamic TAR update disable restore
> the value");

I think this is useless. Either you have enabled message, or have
nothing.

> +		dw_writel(dev, reg, DW_IC_CON);
> Â	}
> Â
> Â	i2c_dw_release_lock(dev);

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy