Re: [PATCH] Staging: arch/x86/kernel/setup.c : fixed empty line style issue

From: Thomas Gleixner
Date: Sat Feb 11 2017 - 14:53:31 EST


On Sat, 11 Feb 2017, Kishore Karanala wrote:

> From: Kishore <kishore.karanala@xxxxxxxxx>
>
> Fixed empty line style issue

What? There is no issue. These empty lines are entirely correct and
removing them is just hurting readability.

Thanks,

tglx

> Signed-off-by: Kishore Karanala <kishore.karanala@xxxxxxxxx>
> ---
> arch/x86/kernel/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index 4cfba94..6d35649 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -723,7 +723,6 @@ static void __init trim_snb_memory(void)
> * already been reserved.
> */
> memblock_reserve(0, 1<<20);
> -
> for (i = 0; i < ARRAY_SIZE(bad_pages); i++) {
> if (memblock_reserve(bad_pages[i], PAGE_SIZE))
> printk(KERN_WARNING "failed to reserve 0x%08lx\n",
> @@ -815,7 +814,6 @@ static void __init trim_low_memory_range(void)
> {
> memblock_reserve(0, ALIGN(reserve_low, PAGE_SIZE));
> }
> -
> /*
> * Dump out kernel offset information on panic.
> */
> --
> 2.7.4
>
>